fix: share the site footer between the home and /why pages#1045
Merged
Conversation
The full marketing footer lived only in app/page.ts, so /why rendered without it. Extract it into lib/site-footer.ts and render it on both pages so the site reads as one system. Section anchors now use /#id so they resolve from any page, not only home. Closes #1044
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The full marketing footer lived inline only in
website/app/page.ts, so/whyrendered without it. Extract it intowebsite/lib/site-footer.tsand render${siteFooter()}on both pages so the site reads as one system. Section anchors now use/#idso they resolve from any page.lib/site-footer.ts: pure SSR-timehtmlhelper (no client globals, never ships the page).app/page.ts: inline footer replaced; trimmed now-unused link imports.app/why/page.ts: renders the shared footer after</main>.Verified:
webjs check+tsc --noEmitpass; both/and/whyserve the footer live.Closes #1044