fix(theme): pass pathname to NavBar for active link highlighting#171
Open
ryzrr wants to merge 1 commit into
Open
fix(theme): pass pathname to NavBar for active link highlighting#171ryzrr wants to merge 1 commit into
ryzrr wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
avivkeller
approved these changes
Jul 5, 2026
moshams272
reviewed
Jul 5, 2026
Comment on lines
16
to
+22
|
|
||
| return ( | ||
| <NavBar | ||
| Logo={Logo} | ||
| sidebarItemTogglerAriaLabel="Toggle navigation menu" | ||
| navItems={navbar} | ||
| pathname={metadata.path} |
Contributor
There was a problem hiding this comment.
Suggested change
| pathname={metadata.path} | |
| const currentPath = metadata.path.startsWith('/') ? metadata.path : `/${metadata.path}`; | |
| return ( | |
| <NavBar | |
| Logo={Logo} | |
| sidebarItemTogglerAriaLabel="Toggle navigation menu" | |
| navItems={navbar} | |
| pathname={currentPath} |
To handle the docs/api link, as we discussed in Discord.
Contributor
There was a problem hiding this comment.
It doesn't appear as I want in suggestion, but u understand me right ?
Member
Author
There was a problem hiding this comment.
yes got it , it totally slipped from my mind
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Passed pathname to NavBar for active link highlighting
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
No
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
NA
Use of AI
No