fix: UTF-8-safe mapper handoff --json on Windows - #581
Merged
Conversation
print(json.dumps(..., ensure_ascii=False)) encodes through the console code page. On cp1252 that raises UnicodeEncodeError for ordinary arrows such as U+2192 and Loop treats a valid pack as mapper failure. Write the JSON via sys.stdout.buffer as UTF-8 so handoff --json succeeds whenever the payload is valid. Closes #580
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
simplicio-mapper handoff --jsoncrashed on Windows cp1252 when the context pack contained→.Change
_print_json_utf8writes the compact JSON payload as UTF-8 bytes throughsys.stdout.buffer, bypassing the console codec. Callers no longer needPYTHONIOENCODING=utf-8.Tests
tests/python/test_handoff_utf8_stdout.pypython -m pytest tests/python/test_handoff_utf8_stdout.py -q→ 3 passedCloses #580