Clean up setup.py#137
Conversation
roberthdevries
commented
Jul 8, 2026
roberthdevries
commented
- remove obsolete merging of LICENSING.rst in description as the include is not there anymore
- put setuptools configuration in pyproject.toml
- the setup_requires setting in setup.py is deprecated and is covered by pyproject.toml [build-system] - requires
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Please resolve merge conflicts. Thanks!
- remove obsolete merging of LICENSING.rst in description as the include is not there anymore - put setuptools configuration in pyproject.toml - the setup_requires setting in setup.py is deprecated and is covered by pyproject.toml [build-system] - requires
738c1a7 to
68c30d2
Compare
|
Rebased on master, conflicts are resolved. |
| setup_requires=["cffi>=1.17"], | ||
| cffi_modules=["./scripts/build_ffi.py:ffibuilder"], | ||
|
|
||
| package_data={"wolfcrypt": ["*.dll", "**/*.pyi", "py.typed"]}, |
There was a problem hiding this comment.
it looks like '.dll' is being dropped from the build. The '.pyi' and 'py.typed' should be fine to remove since I believe they're implicit but a rule needs to be added to pyproject.toml to continue copying '*.dll'.
There was a problem hiding this comment.
The include line on line 50 of pyproject.toml specifies the directories to include in the wheel. On Linux it includes the .so the file by default. So my hopes are that on Windows setuptools would also do this for .dll files by default.
Unfortunately I do not have a development environment under Windows available. Could someone at your end try to run uv build --wheel on a Windows system?
There was a problem hiding this comment.
That should be doable. I'll get back to you once I've tested it.
There was a problem hiding this comment.
I tried adding a workflow to the github actions, but it seems to crash in one of the tests. In any case the tests seems to run for a bit, so at least something is being built. It only seems that no .dll is built, but an .exp file. In any case that file is not included in the wheel (it is not using the changes of this patch).
There was a problem hiding this comment.
Ahh, so this may be broken already - unless we're misunderstanding how this is supposed to be built. Debugging workflows is a bit of a chore so I'll see if I can get it working locally.
I've got a desktop with Windows that I'll get setup this weekend, we'll see what I find come Monday.
sebastian-carpenter
assigned
roberthdevries and
sebastian-carpenter and unassigned
sebastian-carpenter and
roberthdevries
4 participants
