Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/cli/src/producer/generate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,8 @@ export async function generateWorkspaceJson(
//
// The reason itself was already being computed and thrown away — the
// diagnostics object exists for exactly this and was not passed.
// The diagnostics object is passed rather than defaulted: the refusal reason
// is computed inside the mining pass and would otherwise be discarded there.
const refreshDiagnostics: { refusal?: string } = {};
const minedHistory =
options.mineHistory === true ? await mineHistoryBlock(resolvedRoot, refreshDiagnostics) : undefined;
Expand Down
2 changes: 2 additions & 0 deletions packages/mining-core/src/project.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ export type ProjectionResult =
* spelling a producer is permitted to write, which is what makes two
* independent producers byte-comparable.
*/
// `compareUtf8`, never bare `<`: the two disagree above the BMP and the emitted
// bytes are what a second producer is compared against.
function canonicalPair(files: readonly [string, string]): [string, string] {
return compareUtf8(files[0], files[1]) <= 0 ? [files[0], files[1]] : [files[1], files[0]];
}
Expand Down
Loading