Fix nested beehive coordinate filtering#332
Open
yesidodo73 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed beehive coordinate filtering being skipped for some inventory and nested container items.
The
WINDOW_ITEMShandler returned as soon as it encountered an empty slot. Since most inventories contain empty slots, any items after the first empty slot were never checked.Coordinate data removed from beehives inside bundles or container items was also not propagated to the parent component. The nested item was modified, but the parent packet was not marked for re-encoding, so the original coordinate data could still be sent to the client.
The handler now skips empty slots instead of stopping the entire inventory scan, and propagates nested component changes so the updated item is written back and re-encoded.
Applied the same fix to both Folia and Legacy implementations.