Stagger pin labels in staircase layout#9
Merged
Conversation
Owner
|
Thanks for implementing this, helps a lot with long pin names on horizontal connectors. Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
place top/bottom pin labels on separate stepped levels
extend their leader lines to match each label level
keep left/right pin labels vertically aligned because they are already separated
expand the SVG padding so staggered labels are not clipped
keep the Python generator and browser designer renderers in sync
Why
Dense connectors previously placed labels on one shared baseline and reduced the font size to fit the available pin pitch. This made adjacent labels difficult to distinguish and increased the risk of associating a definition with the wrong pin.
The staircase layout preserves a readable label size and gives horizontally arranged pins visually distinct leaders. Connectors whose labels already form a vertical list keep equal leader lengths.
Validation
python -m compileall -q pinout_gen/pinout_gen
node --check pinout_design/js/svg-renderer.js
generated pinout_gen/example.toml successfully
checked that top/bottom orientations stair-step and left/right orientations remain aligned
checked a two-row connector
visually inspected the generated HTML