Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
unknownproperty
left a comment
unknownproperty
left a comment
Contributor
There was a problem hiding this comment.
Нужно также поднять версию пакета иконок, убедиться, что она нормально отрисована в Storybook и сделать npm i в корне репозитория
|
|
||
| export const ActivityLine = ({ ...props }: IconProps) => ( | ||
| <Svg {...props}> | ||
| <path d="M22 12H18L15 21L9 3L6 12H2" stroke="black" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"/> |
Contributor
There was a problem hiding this comment.
Мы переводим иконки из stroke в fill формат иначе не будут корректно работать стили для задания цветов через css
unknownproperty
left a comment
unknownproperty
left a comment
Contributor
There was a problem hiding this comment.
Не вижу обновлённого package-lock
| @@ -1,5 +1,6 @@ | |||
| import { Account } from './icons/Account'; | |||
| import { Activity } from './icons/Activity'; | |||
| import {ActivityLine} from './icons/ActivityLine' | |||
Contributor
There was a problem hiding this comment.
Форматирование сломано
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Добавлена иконка Activity icon для использования её в задаче xi.tutor(modules.board) #163