Skip to content

feat: loosen itemSource mapping requirements - #1283

Open
jwartofsky-yext wants to merge 5 commits into
mainfrom
loosenItemMappingRequirements2
Open

feat: loosen itemSource mapping requirements#1283
jwartofsky-yext wants to merge 5 commits into
mainfrom
loosenItemMappingRequirements2

Conversation

@jwartofsky-yext

Copy link
Copy Markdown
Contributor

Loosens the mapping requirements from itemSource and slottedItemSource to instead only require that at least one of the mapping requirements is satisfied

Instead of requiring all mapped fields to be populated, allow
user to select any field that satisfies at least one of the requirements.
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 166c9310-09e6-432c-ae19-919d44b54426

📥 Commits

Reviewing files that changed from the base of the PR and between b544188 and 3dac016.

⛔ Files ignored due to path filters (1)
  • packages/visual-editor/src/components/testing/screenshots/PhotoGallerySection/[desktop] version 59 with showSectionHeading false.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
📒 Files selected for processing (1)
  • packages/visual-editor/src/docs/components.md

Walkthrough

getFieldsForSelector now filters descendants using only itemSourceTypes. A root is retained when any configured type group has a compatible descendant. Mapped-source filtering and its related validation are removed. MappedSourceFieldFilter no longer exposes mappedSourceTypes. Tests cover matching and non-matching item-source types. Parent-field tooltip wording changes from “must” to “should.” Image slot documentation now uses a grouped styles object.

Possibly related PRs

Suggested labels: create-dev-release

Suggested reviewers: benlife5, asanehisa, mkilpatrick

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: loosening itemSource mapping requirements.
Description check ✅ Passed The description accurately explains that at least one mapping requirement must be satisfied for itemSource and slottedItemSource.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch loosenItemMappingRequirements2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant