Skip to content

ui: update GPUI sidebar dependencies - #21

Merged
BumpyClock merged 3 commits into
mainfrom
fix/gpui-sidebar-toolchain
Jul 16, 2026
Merged

ui: update GPUI sidebar dependencies#21
BumpyClock merged 3 commits into
mainfrom
fix/gpui-sidebar-toolchain

Conversation

@BumpyClock

Copy link
Copy Markdown
Owner

Summary

  • update GPUI to 4332ea7deae4838c12bad6ea64292ca22a33cf98
  • update gpui-component to 95e4b030ae9549e8583741b16121ff4ad2e1f942
  • use the component-owned 8px sidebar inset and rounded surface styling
  • pin Rust 1.95 and satisfy its formatter/Clippy checks

Testing

  • cargo fmt --all -- --check
  • cargo check --workspace --all-targets --locked
  • cargo test --workspace --locked
  • cargo clippy --workspace --all-targets --locked -- --deny warnings
  • native Settings window inspected at 1040x760 and 800x600

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: cc72e149-48bb-4ac2-acc4-8b69e4e3a425

📥 Commits

Reviewing files that changed from the base of the PR and between ee7fd7e and 61d6fcd.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (5)
  • Cargo.toml
  • README.md
  • crates/app/src/ui/settings/state.rs
  • crates/core/src/transcription/model/catalog.rs
  • rust-toolchain.toml

Summary by CodeRabbit

  • Bug Fixes

    • Improved model snapshot selection so the most recently modified snapshot is chosen first.
  • Chores

    • Updated the Rust UI framework dependencies.
    • Standardized development on Rust 1.95.0 with required formatting and linting tools.
  • Documentation

    • Updated prerequisite instructions to reflect the Rust 1.95 requirement.

Walkthrough

The PR pins Rust 1.95.0 and updated GPUI dependencies, revises prerequisite documentation, reorders settings imports, and maintains newest-first ordering when resolving model snapshots.

Changes

Workspace and model resolution

Layer / File(s) Summary
Toolchain and GPUI dependency alignment
rust-toolchain.toml, Cargo.toml, README.md
Pins Rust 1.95.0 with rustfmt and clippy, updates GPUI-related Git revisions, and documents the pinned prerequisite.
Newest model snapshot resolution
crates/core/src/transcription/model/catalog.rs, crates/app/src/ui/settings/state.rs
Uses a reverse timestamp sort for model candidates and reorders two settings imports without changing behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: aditya649

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches a real part of the change by describing GPUI sidebar dependency updates, though it omits other related updates.
Description check ✅ Passed The description clearly relates to the dependency updates, Rust pinning, styling change, and testing in this pull request.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/gpui-sidebar-toolchain

Warning

Review ran into problems

🔥 Problems

These MCP integrations need to be re-authenticated in the Integrations settings: Linear, Notion


Comment @coderabbitai help to get the list of available commands.

@BumpyClock

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@BumpyClock
BumpyClock merged commit a6c0f73 into main Jul 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant