feat(browser): retain MV3 failure profile cleanup evidence - #141
Draft
seonghobae wants to merge 3 commits into
Draft
feat(browser): retain MV3 failure profile cleanup evidence#141seonghobae wants to merge 3 commits into
seonghobae wants to merge 3 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #27 and #28, stacked on unchanged exact PR #139 head
499a6499112a11094279a1386238e26987d771d5.Buyer/reliability gap
The Manifest V3 repeatability lane reuses one temporary browser profile across an initial pass and a restarted pass. A failure in either browser pass previously escaped
_run_restart_trial; the outer loop then retained only the trial number and exception type. It discarded whether the extension-bearing profile was actually removed, and the aggregate compatibility gate had no all-trial teardown proof. A failed compatibility run could therefore lack credential-free cleanup evidence even though profile isolation and repeatable restart behavior are part of the extension-compatibility contract.Dependency
This Draft targets unchanged exact #139 head
499a6499112a11094279a1386238e26987d771d5and must remain Draft while #139/#136 and their prerequisite stack remain active. Current exact head is42af52f77336112c4fbe1da5c5283899f6bd288e. No descendant PR currently targets this branch. No prerequisite check, review, status, coverage, mergeability, or synthetic-merge evidence transfers.TDD and RCA sequence
7df005847ffc45526de42bf6bf7a8ec6c959cbe0required failed initial/restart browser work to return bounded teardown evidence only after the temporary-profile context exited, and required one all-trial Manifest V3 cleanup evidence/gate boundary.31657604009, Rust contracts job94315391134, passed checkout and Rust setup and then failed at the Python repository-contract boundary because the mockedRuntimeErrorstill escaped andmv3_profiles_cleanedplus the dedicated cleanup gate did not exist. This is the valid RED. The independently successful Rust production-coverage job on that test-only Python head is not promoted as source GREEN.2301459a20bd5561054b7dd7d2151fd327634026catches only the reviewed browser-run failure classes inside the temporary-profile lifecycle, verifies deletion after context exit, emits bounded success/failure cleanup evidence, and adds the all-trial aggregate evidence and fail-closed gate.42af52f77336112c4fbe1da5c5283899f6bd288eadds only the truthful Unreleased changelog entry for that implemented boundary.Implemented contract
_run_restart_trialnow:OSError,ValueError,RuntimeError, andjson.JSONDecodeErroraround both the initial and restarted browser passes;trial_number,passed: false,failure_type,profile_cleaned: true, and duration when browser work fails but teardown succeeds;profile_cleaned: true; andThe aggregate compatibility path now computes
mv3_profiles_cleanedacross every trial without filtering failures, emitsprofiles_cleanedin top-level evidence, and appliesManifest V3 profile cleanup gate failedbefore repeatability acceptance. An outer failure lacking cleanup proof therefore fails closed rather than inventing successful teardown evidence.Exact-head proof
On unchanged exact head
42af52f77336112c4fbe1da5c5283899f6bd288eagainst unchanged exact prerequisite499a6499112a11094279a1386238e26987d771d5:31660680288: success;94324664028: Python repository contracts, canonical formatting, locked workspace/all-target check, full tests, strict Clippy, and rustdoc success;94324664078: exact owned production function/line/region/branch enforcement success;31660680311: success;No predecessor-head, prerequisite, synthetic-merge, skipped, cancelled, absent, pending, or stale evidence is promoted as current proof.
Truth boundary
This lane records controlled temporary-profile teardown evidence for the pinned Manifest V3 compatibility runner only. It does not prove browser-process termination, adversarial filesystem erasure, removal of every extension artifact outside the temporary profile, extension-update rollback, browser/adapter authenticity, general enterprise profile isolation, durable incident evidence, or completion of #27/#28. A production runtime still needs trusted task/process ownership, recovery evidence, and separately reviewed cleanup/retention semantics.