test(browser): require sampled Chromium process-set termination evidence - #144
Draft
seonghobae wants to merge 3 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #28, stacked on exact current PR #143 head
d2dbf3bbee883b91812690089bb33bd274a4687a.Buyer/reliability gap
PR #143 proves PID-reuse-safe teardown evidence for the exact Chrome root process after both successful and reviewed failed controlled Agent Tasks. Chromium is multi-process, so renderer, GPU, utility, and other descendants sampled before shutdown can survive even when the root exits. This lane extends the controlled acceptance boundary to the entire exact sampled Chromium process set.
Dependency
This Draft targets exact current #143 head
d2dbf3bbee883b91812690089bb33bd274a4687aand must remain Draft while #143 and its prerequisite stack remain active. No prerequisite check, review, status, coverage, mergeability, synthetic-merge, predecessor-head, skipped, cancelled, queued, or absent evidence transfers.TDD evidence
Exact test-only RED head
d20fd0f0d02e4c9d58a5c471b25b13e82d9ddac3ran CI31673100891; Rust contracts job94361750201failed first atCheck Python repository contracts, while the production-coverage job was green because production support was intentionally absent from that test-only head.Production support was added on
9c3af05a889160844e487710e4fa37bad1d89a6aand the canonical changelog was then reconciled on the current exact headfea7bec6a3ef3f378884b717d36028d9103bde92.The implemented boundary:
/proc/<pid>/statPID/start-time identity before shutdown;chromium_process_set_terminated: truein successful Agent Task evidence and aggregate acceptance.Current exact-head proof on
fea7bec6a3ef3f378884b717d36028d9103bde92:31676844681: completed successfully;31676844704: completed successfully.There are currently no formal reviews, requested reviewers, or unresolved review threads on this exact head. The PR remains Draft because its prerequisite stack remains active and scheduled agents are not authorized to merge.
Truth boundary
This lane proves only the exact bounded Linux Chromium process set discovered from the runner's sampled
/proclineage snapshot before shutdown. It does not prove cgroup/task ownership beyond that sampled lineage, processes that appear only after the snapshot, cross-platform process supervision, authenticated Chromium/ChromeDriver provenance, OS-wide orphan absence, or completion of #28.