feat(extension): bound Agent Task managed extension admission - #85
Draft
seonghobae wants to merge 6 commits into
Draft
feat(extension): bound Agent Task managed extension admission#85seonghobae wants to merge 6 commits into
seonghobae wants to merge 6 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #27, stacked on PR #83.
Buyer/security gap
Issue #27 requires Agent Task mode to default to no extensions or an explicit managed allow-list. Existing work separates Chromium extension permissions, OriginWeave Agent grants, native-messaging host authority, and attached-tab assurance, but there was no production policy primitive that answered the narrower question: may this exact extension identity be present in an isolated Agent Task profile under the managed extension admission policy?
Dependency and exact stack state
This Draft now targets exact current PR #83 head
204cedb1bee54a40a6d6bc0b97719afd309c3f71; this PR is exact heade836e833be920da8764d3dd72e058e02cd9ed72b.After #83 was aligned non-destructively to current #82, this branch became topologically stale even though the prerequisite merge changed no tree content. A second non-destructive merge-topology commit added current #83 as the parent while preserving the existing #85 tree. Fresh compare now reports #85 ahead of current #83 with
behind_by=0and merge base exactly204cedb1bee54a40a6d6bc0b97719afd309c3f71. No prerequisite review/check is transferred.TDD / RCA sequence
23f128fc84b2d2b5b4c188211575ef69c5c5d070established the intended production-boundary RED. CI run31490857300, Rust contracts job93776779728, passed repository contracts and formatting then failed at the workspace check with E0432 because the managed Agent Task admission API did not exist.originweave-policy, notoriginweave-core: core owns stable extension identity/grant value contracts, while policy owns fail-closed decisions. The test was therefore moved to the policy crate rather than widening the core authority surface.AgentTaskExtensionPolicy,AgentTaskExtensionDecision, andevaluate_agent_task_extension. An empty policy denies all; only exact canonicalExtensionIdmembership is admitted; duplicate entries collapse without widening authority; and policy admission never mintsExtensionAgentGrantcapability.Exact-head verification
For exact current head
e836e833be920da8764d3dd72e058e02cd9ed72b:31536909167: success;93930058899: success, including repository contracts, formatting, locked workspace/all-target check, full tests, strict Clippy and rustdoc;93930058924: success, including exact owned production function/line/region/branch enforcement;No predecessor-head check, review, mergeability result, or synthetic status is transferred to this current head.
Truth boundary
This policy primitive does not read Chrome enterprise policy, install/enable/disable extensions, verify signatures or update provenance, mutate a browser profile, launch Chromium, persist policy, authenticate an administrator, authorize native messaging, or grant any OriginWeave Agent capability/action. A future trusted profile/enterprise-policy adapter must derive the exact managed extension set from independently authenticated policy and compose it with Chromium startup/install state.
Keep Draft while #83/#82 remain active. This PR does not close #27.