chore: superseded by current-base focus PR #334

[seonghobae]

Superseded by clean current-base reconstruction

Closed in favor of PR #334.

PR #334 rebuilds the same bounded focus-appearance contract directly on protected main 55d7ae8647208e301f282350f076eeddaba61d11. Its exact changed blobs are:

• scripts/test_viewer_focus_appearance.py: ad1509e12b147582f6e3e824b9ff00fb34921b8e;
• src/main/resources/static/assets/viewer/viewer.css: 3c19c3baccaaffdf1aa5277187591703aa8deb07.

The current replacement head d080540076703d2e94940522f18ac6be86d2da37 is GREEN on CI 31389256791, Security Scan 31389256767, SAST 31389256739, and fuzz 31389256710; auto-merge is enabled through normal protection. The final commit changes no file content and exists only because the initial clean head had no Actions runs associated with it.

Keeping both PRs would duplicate identical path ownership, review traffic, and merge risk. Issue #324 remains the product/standards authority until the protected replacement integrates.

[coderabbitai]

📝 Walkthrough

Walkthrough

뷰어의 :focus-visible 표시를 검은색 외곽선과 흰색 그림자로 변경했습니다. 새 테스트 스크립트는 CSS를 해석하고, 밝은 배경과 어두운 배경에서 포커스 표시의 대비율과 누적 폭을 검증합니다.

Changes

포커스 표시 대비 계약

Layer / File(s)	Summary
포커스 표시 스타일 변경 src/main/resources/static/assets/viewer/viewer.css	:focus-visible 스타일이 테마 색상과 color-mix() 외곽선 대신 검은색 3px 외곽선과 흰색 3px box-shadow를 사용합니다.
포커스 표시 대비 검증 scripts/test_viewer_focus_appearance.py	CSS 변수와 제한된 색상 표현을 해석합니다. WCAG 상대 휘도와 대비율을 계산합니다. 밝은 배경과 어두운 배경에서 대비율 3:1 이상인 밴드의 누적 폭이 2px 이상인지 unittest로 검증합니다.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related issues

• ContextualWisdomLab/clearfolio#324: 밝은 배경과 어두운 배경 모두에서 포커스 표시 대비를 검증하는 CSS 테스트와 포커스 링 변경을 구현합니다.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	제목은 키보드 포커스 링의 대비를 개선하는 주요 변경 사항을 정확하고 간결하게 설명합니다.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/focus-appearance-contrast

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@scripts/test_viewer_focus_appearance.py`:
- Around line 114-134: Update _focus_bands to parse the focus rule’s
outline-offset and account for it when processing the box-shadow band. Before
adding the shadow as a separate visible FocusBand, validate that the offset is
at least the shadow spread, or reduce the band width to only the exposed
portion, preventing overlapping outline and shadow widths from being summed.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7ceacc7f-f2ce-441b-ab3b-412d9f792623

📥 Commits

Reviewing files that changed from the base of the PR and between 83ec6f7 and 1262c1a.

📒 Files selected for processing (2)

• scripts/test_viewer_focus_appearance.py
• src/main/resources/static/assets/viewer/viewer.css

[seonghobae]

@opencode-agent @cwl-noema-review Please independently review exact current head 2aa49e8508a76a126450ab7dddb6a4a2bcbc7124 against protected main 83ec6f7fe2b04bdcd28bf98ec350e41e55730a18. Exact-head CI 31376605522, Security Scan 31376605703, SAST Semgrep 31376605216, and fuzz 31376605728 are successful; CodeRabbit's outline-offset finding is resolved on this head. Verify the bounded WCAG 2.2 focus-appearance change and deterministic CSS contrast/visible-band regression without broadening scope. Submit formal review only if supported for this exact head; do not mutate the branch, merge, or weaken gates.