fix(accessibility): reconcile robust focus appearance after #270 - #334
fix(accessibility): reconcile robust focus appearance after #270#334seonghobae wants to merge 4 commits into
Conversation
|
Warning Review limit reached
Next review available in: 8 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@opencode-agent @cwl-noema-review Please independently review exact current head |
Objective
Reconstruct the bounded WCAG focus-appearance fix directly on the protected-main baseline after #270 integrated, so base-sensitive verification runs without predecessor ancestry.
Fresh exact state — 2026-08-10
d080540076703d2e94940522f18ac6be86d2da37;main:55d7ae8647208e301f282350f076eeddaba61d11;31389256791: success;31389256767: success;31389256739: success;31389256710: success;Preserved accessibility contract
The shipped
:focus-visiblerule uses:The deterministic contract computes WCAG relative luminance and contrast, requiring at least 2 CSS px at >=3:1 against both white and black reference surfaces. It also prevents overlapping outline/shadow pixels from being double-counted by limiting the exposed shadow band to the outline offset.
Exact source identity
Changed blobs:
scripts/test_viewer_focus_appearance.py:ad1509e12b147582f6e3e824b9ff00fb34921b8e;src/main/resources/static/assets/viewer/viewer.css:3c19c3baccaaffdf1aa5277187591703aa8deb07.The protected-main CSS before reconstruction was byte-identical to the former #325 base, proving #270 did not modify this path. #325 remains predecessor evidence only and is superseded by this current-base branch.
Scope / non-completion boundary
This two-file slice does not modify viewer generation ownership (#322/#323), demo/session authority (#317), nested asynchronous controls (#264), Java controllers, build metadata, or canonical cross-cutting documentation. Issue #324 remains the product and standards authority.
Merge gate
Keep this exact head unchanged. Auto-merge may complete only after live repository protection still sees all required checks passing, zero valid unresolved findings, and the counted approving review from a qualifying independent reviewer with write access. Automated evidence is not approval.