Skip to content

feat(auth): define provider-neutral identity verifier contract - #343

Open
seonghobae wants to merge 4 commits into
mainfrom
feat/identity-verifier-contract-main-20260811
Open

feat(auth): define provider-neutral identity verifier contract#343
seonghobae wants to merge 4 commits into
mainfrom
feat/identity-verifier-contract-main-20260811

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Objective

Advance issue #314 with the smallest path-disjoint production identity slice: define a versioned provider-neutral verifier port that can resolve an opaque bearer credential into Clearfolio's immutable TenantContext without coupling controllers or business logic to a specific IdP/JWT library.

Exact test-first evidence

Base is current protected main 55d7ae8647208e301f282350f076eeddaba61d11.

  • RED head fb2e0baf6036e9582e9dade4f9f5dfc8d38c20d9: CI run 31402280669, Maven job 93499938982, exact-head checkout verified and testCompile failed because IdentityVerifier and IdentityVerificationException did not exist.
  • First implementation head 480ec0835ee5170c5b7e6ab1506952f1212e3602: 500 tests passed with zero failures/errors/skips and JaCoCo reported all coverage checks met. Security Scan, SAST Semgrep and fuzz passed. CI correctly remained red because the strict Javadoc gate found one undocumented private failure-kind field.
  • Final head bc4418b4d1a88adcb73c07da61876414d49aac30: the Javadoc RCA was fixed without changing behavior. Exact-head CI run 31402928985, Security Scan 31402928773, SAST Semgrep 31402924547, and fuzz 31402924655 all completed successfully.

Scope boundary

This does not implement OIDC discovery/JWK validation, JWT parsing, opaque-token introspection, controller routing, tenant-role mapping, current HMAC migration, or credential registry work. It adds only the provider-neutral seam and controlled rejection/unavailability categories needed for those later adapters. Existing signed tenant-header auth remains unchanged.

No issue is closed by this foundation; #314 remains the production identity authority.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 21 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 06400d98-dfdc-471f-83e7-b764ffa69548

📥 Commits

Reviewing files that changed from the base of the PR and between 55d7ae8 and bc4418b.

📒 Files selected for processing (3)
  • src/main/java/com/clearfolio/viewer/auth/IdentityVerificationException.java
  • src/main/java/com/clearfolio/viewer/auth/IdentityVerifier.java
  • src/test/java/com/clearfolio/viewer/auth/IdentityVerifierContractTest.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant