feat(security): define provider-neutral credential registry contract - #344
feat(security): define provider-neutral credential registry contract#344seonghobae wants to merge 5 commits into
Conversation
|
Warning Review limit reached
Next review available in: 19 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Objective
Advance issue #319 with a path-disjoint credential-source foundation: define a versioned provider-neutral registry contract, purpose-separated signing-key identities, and a secret snapshot that defensively copies material and redacts it from string output.
Exact test-first evidence
Base is current protected
main55d7ae8647208e301f282350f076eeddaba61d11.4b70001c7439a8b470de0bdea7c7aa503e4fc7dd: CI run31402673468, Maven job93501237441, exact-head checkout verified andtestCompilefailed with the expected missingCredentialReference,CredentialPurpose,CredentialSnapshot, andCredentialRegistryproduction types.f7335f979eca75b125199760b4f7dc538733b8b0: exact-head CI run31403225295completed successfully. Maven job93503124038checked out that exact SHA, ran 500 tests with zero failures/errors/skips, reported all JaCoCo coverage checks met, and passed the strict Javadoc gate. Maven merge compatibility also passed.31403228455, SAST Semgrep31403225078, and fuzz31403225121all completed successfully.Scope boundary
This does not yet migrate
TenantAccessService,ArtifactLinkService, Spring configuration, environment bootstrap, persistence, encryption/KMS, rotation windows, or production adapters. It establishes only the versioned leaf contract required to migrate those consumers without binding Clearfolio business/auth code to one secret-manager SDK or database.No issue is closed by this foundation; #319 remains the credential-source architecture authority.