Skip to content

feat(security): define provider-neutral credential registry contract - #344

Open
seonghobae wants to merge 5 commits into
mainfrom
feat/credential-registry-contract-main-20260811
Open

feat(security): define provider-neutral credential registry contract#344
seonghobae wants to merge 5 commits into
mainfrom
feat/credential-registry-contract-main-20260811

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Objective

Advance issue #319 with a path-disjoint credential-source foundation: define a versioned provider-neutral registry contract, purpose-separated signing-key identities, and a secret snapshot that defensively copies material and redacts it from string output.

Exact test-first evidence

Base is current protected main 55d7ae8647208e301f282350f076eeddaba61d11.

  • RED head 4b70001c7439a8b470de0bdea7c7aa503e4fc7dd: CI run 31402673468, Maven job 93501237441, exact-head checkout verified and testCompile failed with the expected missing CredentialReference, CredentialPurpose, CredentialSnapshot, and CredentialRegistry production types.
  • Final head f7335f979eca75b125199760b4f7dc538733b8b0: exact-head CI run 31403225295 completed successfully. Maven job 93503124038 checked out that exact SHA, ran 500 tests with zero failures/errors/skips, reported all JaCoCo coverage checks met, and passed the strict Javadoc gate. Maven merge compatibility also passed.
  • Exact-head Security Scan 31403228455, SAST Semgrep 31403225078, and fuzz 31403225121 all completed successfully.

Scope boundary

This does not yet migrate TenantAccessService, ArtifactLinkService, Spring configuration, environment bootstrap, persistence, encryption/KMS, rotation windows, or production adapters. It establishes only the versioned leaf contract required to migrate those consumers without binding Clearfolio business/auth code to one secret-manager SDK or database.

No issue is closed by this foundation; #319 remains the credential-source architecture authority.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 19 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e2669d0a-d985-4099-bc36-9871e48a720e

📥 Commits

Reviewing files that changed from the base of the PR and between 55d7ae8 and f7335f9.

📒 Files selected for processing (5)
  • src/main/java/com/clearfolio/viewer/credential/CredentialPurpose.java
  • src/main/java/com/clearfolio/viewer/credential/CredentialReference.java
  • src/main/java/com/clearfolio/viewer/credential/CredentialRegistry.java
  • src/main/java/com/clearfolio/viewer/credential/CredentialSnapshot.java
  • src/test/java/com/clearfolio/viewer/credential/CredentialRegistryContractTest.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 10, 2026 15:26
@seonghobae
seonghobae enabled auto-merge (squash) August 10, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant