Skip to content

fix(reliability): serialize same-job artifact lifecycle work - #350

Open
seonghobae wants to merge 2 commits into
mainfrom
fix/lifecycle-lock-registry-main-20260811
Open

fix(reliability): serialize same-job artifact lifecycle work#350
seonghobae wants to merge 2 commits into
mainfrom
fix/lifecycle-lock-registry-main-20260811

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

Objective

Reconcile one path-local lifecycle fencing primitive from stale descendant #268 onto the exact current protected-main baseline without importing stale ancestry. The standalone runtime needs bounded process-local serialization so conversion and deletion work for the same permanently reserved job identifier cannot mutate artifact state concurrently.

Test-first state

This Draft is intentionally RED at test-only head a66a5c971bb5e49221083aac9966311dd6396b6c. The regression requires a fixed-memory ArtifactLifecycleLockRegistry, proves same-job exclusion, verifies lock release after action failure, and requires fail-fast construction/null-input behavior. Protected main does not contain the production registry, so test compilation is expected to fail until the narrow production primitive is restored.

Scope

This is a clean current-base reconciliation of one unique #268 semantic. It does not copy deletion receipt/ledger/coordinator code, repository generation fencing, admin APIs, audit policy, viewer code, Office conversion, credential/OIDC work, or canonical documentation. The JVM-local registry is not durable/distributed locking and does not complete #263 or #312.

Acceptance

Observe exact-head RED -> add only the production registry -> exact-head mvn -B --no-transfer-progress verify, 100% owned coverage/public Javadocs -> CI/Security Scan/SAST/fuzz -> live reviews/threads/base refetch. Keep Draft until GREEN exact-head evidence exists; independent write-authorized approval remains a separate merge gate.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 30 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0f62bb59-4b6e-4dd2-a581-a0bab9ed0672

📥 Commits

Reviewing files that changed from the base of the PR and between 55d7ae8 and 914b7e5.

📒 Files selected for processing (2)
  • src/main/java/com/clearfolio/viewer/lifecycle/ArtifactLifecycleLockRegistry.java
  • src/test/java/com/clearfolio/viewer/lifecycle/ArtifactLifecycleLockRegistryTest.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant