fix(security): fail closed on tenant-scoped job ID lookup - #361
Draft
seonghobae wants to merge 4 commits into
Draft
fix(security): fail closed on tenant-scoped job ID lookup#361seonghobae wants to merge 4 commits into
seonghobae wants to merge 4 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Close the remaining tenant-scoped identifier lookup blind spot directly after #342 without moving its verified exact head. The repository contract currently implements
findByTenantAndId(...)as a globalfindById(...)followed by an in-process ownership filter, which is unsafe as the default contract for future durable adapters and undermines storage-boundary tenant isolation.Test-first state
This Draft starts intentionally RED at exact test-only head
a28d936195b40b1442d7ebeae5f4c86657c01bcd. The focused regression requires the interface default to fail closed without invoking globalfindById, and requires the process-local adapter to resolve tenant ownership directly from its scoped storage boundary while rejecting missing tenant/job authority and concealing foreign jobs.Stack and scope
This PR is deliberately stacked on #342 exact head
4eeba73d70db172e44062891c01273efc4109d93because both slices ownConversionJobRepositoryandInMemoryConversionJobRepository. It does not move #342, edit AdminController, overlap the active Jules admin PR, change content-hash demo compatibility, implement durable persistence, or claim issue #326/#312/#263 completion.Acceptance
Observe exact-head RED -> smallest fail-closed contract and in-memory override -> exact-head Maven verification with repository coverage/Javadoc gates -> applicable CI/security/fuzz evidence -> current review/thread/base refetch. Keep Draft while #342 remains open; after #342 integrates, reconcile this unique delta onto the new protected main and regenerate base-sensitive evidence before final merge. Independent write-authorized approval remains a separate protected-merge gate.