fix(governance): restack independent approval audit after nanoid - #90
Open
seonghobae wants to merge 4 commits into
Open
fix(governance): restack independent approval audit after nanoid#90seonghobae wants to merge 4 commits into
seonghobae wants to merge 4 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthrough활성 PR 규칙의 승인 리뷰 요구 검증을 추가했습니다. 보안 스캔 게이트 안내를 보호된 기본 브랜치와 스택형 PR 동작에 맞게 수정했습니다. 관련 감사 테스트와 문서 검증 테스트를 추가했습니다. Changes거버넌스 및 보안 스캔 규칙
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
marked this pull request as ready for review
August 10, 2026 07:40
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Clean protected-main successor to superseded #87 after #76 integrated. This PR starts from current protected
mainand replays only #87's unique governance/Security-Scan guidance delta; predecessor and sibling checks/reviews do not transfer.Test-first proof
Exact RED head
f0ee29936cc3f46f38c04b5f32992396e4b543faran application CI and failed exactly two intended contracts intest/main-governance-audit.test.ts:required_approving_review_countwas zero;AGENTS.mdstill claimed central Security Scan ran on every stacked PR and documented a staleCRITICAL/HIGHthreshold.The narrow GREEN implementation then changed only:
test/main-governance-audit.test.ts;scripts/lib/main-governance-audit.mjs;AGENTS.md.Current exact head:
4ee417372c7a7e084767b50692c376bf03ff4b0a.Implemented boundary
AGENTS.mdnow matches the live central Security Scan event contract: protected bases (main,master,develop) are eligible, feature-base absence is non-passing evidence that must be refreshed after dependency integration, and the fixable Trivy boundary isMEDIUM/HIGH/CRITICAL;Current exact-head verification
For unchanged exact head
4ee417372c7a7e084767b50692c376bf03ff4b0a:cirun31366570251: terminal success;reviewer-cirun31366570220: terminal success;Security Scanrun31366570232: terminal success under its own scanner/revision semantics;The successful technical gates do not create live ruleset evidence or a qualifying independent formal approval. Issue #27 remains the enforceable-governance owner and #29 remains the Reviewer/Maintainer App provisioning owner.
Supersession
#87 was closed only after proving this clean protected-main successor preserves its three unique final blobs exactly. Old #87 checks/reviews do not transfer.
No repair workflow, self-modifying Action, force-push, synthetic approval, protection weakening, version bump, release or deployment authority is introduced.
Summary by CodeRabbit
문서
버그 수정
테스트