Fix root pytest failures#360
Closed
namabeeru wants to merge 3 commits into
Closed
Conversation
CraftBot V1.4.0 update: Sub-agents, improved Memory system, improved agent workflow, and a big UI overhaul
🧩 CraftBot V1.4.0 update: Sub-agents, improved Memory system, improved agent workflow, and a big UI overhaul
Contributor
Author
|
Retargeted this PR to |
Contributor
Author
|
Closing this in favor of #361, which contains the same two-file fix rebuilt from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/suite.generate_response_async(..., prompt_name=...)call shape.ROUTE_TO_SESSIONprompt name into the LLM call.Root cause
Plain
pytestfrom the repository root was collecting generated/template Living UI tests underapp/data. Those tests are either intended to run from a generated backend project or from their own backend directory, not as part of CraftBot's root suite, so root collection failed before the maintained tests could run.The router tests also had a stale fake LLM signature. Product code now passes
prompt_name="ROUTE_TO_SESSION", which matches the currentagent_coreLLM implementation, but the fake rejected that keyword.Validation
/usr/local/bin/python3.10 -m pytest tests/test_trigger_router_and_parking.py -q->9 passed/usr/local/bin/python3.10 -m pytest --collect-only -q->99/115 tests collected (16 deselected)/usr/local/bin/python3.10 -m pytest -q->99 passed, 16 deselected20/20successful runs, each99 passed, 16 deselected/usr/local/bin/python3.10 -m pytest app/data/living_ui_template/backend/tests -q->4 passedwhen invoked explicitly/usr/local/bin/python3.10 -m py_compile tests/test_trigger_router_and_parking.py-> passedgit diff --check HEAD^..HEAD-> passedNote: Ruff is not installed in this local environment, so I could not run
ruff format --check/ruff checklocally.