fix: root pytest failures#361
Open
namabeeru wants to merge 1 commit into
Open
Conversation
Signed-off-by: namabeeru <github.body594@passmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tests/suite.generate_response_async(..., prompt_name=...)call shape.ROUTE_TO_SESSIONinto the LLM call.Why
Root
pytestwas collecting generated/template Living UI tests underapp/data, which are not part of CraftBot's maintained root suite and can fail collection from the repository root. The router tests also had a stale fake LLM signature after router calls started passingprompt_namefor prompt capture.This replaces #360 with a clean branch based directly on
dev; the old PR had the right file diff but included unrelatedmainmerge commits in its PR commit list after retargeting.How to test
/usr/local/bin/python3.10 -m pytest tests/test_trigger_router_and_parking.py -q->9 passed/usr/local/bin/python3.10 -m pytest --collect-only -q->99/115 tests collected (16 deselected)/usr/local/bin/python3.10 -m pytest -q->99 passed, 16 deselected20/20successful runs, each99 passed, 16 deselected/usr/local/bin/python3.10 -m pytest app/data/living_ui_template/backend/tests -q->4 passedwhen invoked explicitly/usr/local/bin/python3.10 -m ruff format --check .->588 files already formatted/usr/local/bin/python3.10 -m ruff check .->All checks passed!/usr/local/bin/python3.10 -m compileall -q app agent_core agents decorators skills-> passed/usr/local/bin/python3.10 -m py_compile tests/test_trigger_router_and_parking.py-> passedgit diff --check HEAD^..HEAD-> passed