Add secrets to the Run Configuration, via SecretStorage - #19
Open
ChrisonSimtian wants to merge 1 commit into
Open
Add secrets to the Run Configuration, via SecretStorage#19ChrisonSimtian wants to merge 1 commit into
ChrisonSimtian wants to merge 1 commit into
Conversation
ChrisonSimtian
added
enhancement
This was referenced Aug 14, 2026
Secrets a local run needs — a feed token, a signing password — alongside the plain parameters, but handled differently at every step. Values go to VS Code's SecretStorage, which is OS keychain-backed, rather than workspaceState; only the *names* are kept in workspace state so the view can list them. The webview is never sent a value: it renders a fixed mask, so a secret cannot leak through a webview devtools inspection or a state snapshot. They resolve to environment variables rather than CLI arguments. An argument would appear in shell history and in the process list, where any other process on the machine can read it; the environment of a spawned process is not exposed that way. buildEnv() resolves them at run time rather than caching, so a secret rotated in the keychain takes effect on the next run without reloading the window. Nothing consumes the environment yet; wiring it into the run flow is #14. Closes #13 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ChrisonSimtian
force-pushed
the
feature/run-config-parameters
branch
from
August 14, 2026 23:50
4a991d8 to
92dc0dc
Compare
ChrisonSimtian
force-pushed
the
feature/run-config-secrets
branch
from
August 14, 2026 23:50
6975a61 to
f9e9693
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5/6 of the #2 split. Closes #13. Based on #18.
Secrets a local run needs — a feed token, a signing password — alongside the plain parameters, but handled differently at every step.
Three deliberate differences from parameters
Values go to
SecretStorage(OS keychain-backed), notworkspaceState. Only the names are kept in workspace state, so the view can list them.The webview is never sent a value. It renders a fixed mask, so a secret cannot leak through webview devtools or a persisted state snapshot. Values are write-only from the UI's perspective.
They resolve to environment variables, not CLI arguments. An argument appears in shell history and in the process list, readable by any other process on the machine; a spawned process's environment is not exposed that way.
buildEnv()resolves at run time rather than caching, so a secret rotated in the keychain takes effect on the next run without reloading the window.Nothing consumes the environment yet; that is #14.
🤖 Generated with Claude Code