Skip to content

Reject masked manifold EMA weights - #4942

Merged
FlorianPfaff merged 2 commits into
mainfrom
agent/reject-masked-manifold-ema-alpha-20260730
Jul 30, 2026
Merged

Reject masked manifold EMA weights#4942
FlorianPfaff merged 2 commits into
mainfrom
agent/reject-masked-manifold-ema-alpha-20260730

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

What changed

  • reject genuinely masked alpha values before NumPy conversion can expose their hidden payload
  • preserve support for fully unmasked scalar MaskedArray weights
  • add constructor and setter regression coverage, including preservation of the previous weight after a rejected assignment

Root cause

np.asarray(...) drops MaskedArray mask metadata. Consequently, np.ma.masked was interpreted as 0.0, while a masked scalar such as np.ma.array(0.25, mask=True) was interpreted as its hidden value 0.25. Both values silently changed the exponential moving average despite being explicitly unavailable data.

Impact

A missing or invalid smoothing weight could freeze the filter or apply an unintended update rate without raising an error.

Validation

  • focused regression tests added in tests/filters/test_manifold_exponential_moving_average.py
  • source and test files are syntactically valid
  • GitHub CI should run the repository's supported backend/test matrix on this PR

@FlorianPfaff
FlorianPfaff marked this pull request as ready for review July 30, 2026 09:07
@FlorianPfaff
FlorianPfaff enabled auto-merge (squash) July 30, 2026 09:07
@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 22.59s
✅ JSON prettier 7 0 0 0 1.07s
✅ JSON v8r 7 0 0 4.55s
✅ MARKDOWN markdownlint 68 0 0 0 1.81s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.77s
✅ PYTHON black 1794 47 0 0 84.09s
✅ PYTHON isort 1794 75 0 0 2.51s
✅ REPOSITORY betterleaks yes no no 2.33s
✅ REPOSITORY checkov yes no no 52.29s
✅ REPOSITORY gitleaks yes no no 15.54s
✅ REPOSITORY git_diff yes no no 0.11s
✅ REPOSITORY secretlint yes no no 72.21s
✅ REPOSITORY syft yes no no 5.51s
✅ REPOSITORY trivy-sbom yes no no 6.32s
✅ REPOSITORY trufflehog yes no no 32.08s
✅ YAML prettier 11 0 0 0 0.61s
✅ YAML v8r 11 0 0 12.13s
✅ YAML yamllint 11 0 0 0.56s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff
FlorianPfaff merged commit 039f52d into main Jul 30, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant