Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/pyrecest/filters/manifold_exponential_moving_average.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ def __init__(
@staticmethod
def _validate_alpha(alpha: float) -> float:
message = "alpha must be a real scalar between 0 and 1"
if np.ma.is_masked(alpha):
raise TypeError(message)
try:
alpha_array = np.asarray(alpha)
except (TypeError, ValueError) as exc:
Expand Down
29 changes: 29 additions & 0 deletions tests/filters/test_manifold_exponential_moving_average.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,35 @@ def test_alpha_rejects_boolean_values(self):
with self.assertRaisesRegex(TypeError, "real scalar"):
ema.alpha = True

def test_alpha_rejects_masked_values_without_changing_current_weight(self):
masked_values = (
np.ma.masked,
np.ma.array(0.25, mask=True),
)
for alpha in masked_values:
with self.subTest(alpha=alpha):
with self.assertRaisesRegex(TypeError, "real scalar"):
ManifoldExponentialMovingAverage(
initial_state=0.0,
alpha=alpha,
phi=_phi_so2,
phi_inv=_phi_inv_so2,
)

ema = ManifoldExponentialMovingAverage(
initial_state=0.0,
alpha=np.ma.array(0.5, mask=False),
phi=_phi_so2,
phi_inv=_phi_inv_so2,
)
self.assertEqual(ema.alpha, 0.5)

for alpha in masked_values:
with self.subTest(alpha=alpha):
with self.assertRaisesRegex(TypeError, "real scalar"):
ema.alpha = alpha
self.assertEqual(ema.alpha, 0.5)

def test_alpha_rejects_text_values(self):
for alpha in ("0.5", b"0.5", np.array("0.5")):
with self.subTest(alpha=alpha):
Expand Down
Loading