Fix cancellation in Merwe sigma-point scaling - #4945
Merged
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
FlorianPfaff
marked this pull request as ready for review
July 30, 2026 14:50
FlorianPfaff
enabled auto-merge (squash)
July 30, 2026 14:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changed
alpha**2 * (n + kappa)instead of reconstructing it throughn + (scale - n)ValueErrorsRoot cause
The implementation first formed
lambda = alpha**2 * (n + kappa) - nand then reconstructed the covariance factor asn + lambda. When the intended factor is small relative ton, the subtraction and re-addition lose significant digits through catastrophic cancellation.For
n=1,kappa=0, andalpha=2e-8, the intended scale is4.0e-16, but the reconstructed scale is4.440892098500626e-16. This inflates the scale by about 11.02% and the sigma-point displacement by about 5.37%.Impact
Small but representable Merwe scaling parameters now produce the requested sigma-point spread instead of a rounded, wider spread. Parameter combinations that cannot produce finite and normalized float64 weights fail clearly rather than returning distorted weights or leaking
ZeroDivisionError/OverflowError.Validation
±2e-8sigma-point offsetstests/test_sigma_points_merwe_scale_stability.pymainand zero behind; full repository CI is pending