refactor: decompose large source and test files#798
Draft
FuJacob wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Decomposes the largest mixed-responsibility files into cohesive suggestion-domain models, engine-pane sections, overlay view content, and focused test suites. The change is intentionally behavior-preserving and makes the next settings/coordinator refactors reviewable at their actual ownership boundaries.
Validation
swiftlint lint --quiet— exit 0xcodegen generate— project regenerated successfullyxcodebuild -project Cotabby.xcodeproj -scheme Cotabby -destination 'platform=macOS' build-for-testing -derivedDataPath build/DerivedData— TEST BUILD SUCCEEDEDtest-without-buildingwas attempted; the test host could not load the ad-hoc-signed bundle because the app and test bundle have different Team IDs. This is the repository's known local hosted-test signing limitation; compilation and linking succeeded.Linked issues
None.
Risk / rollout notes
This PR is stacked on #797. Cross-file
EngineAndModelPaneViewextension members are module-internal because Swift cannot share lexicalprivateaccess across files; the view type itself remains internal and no public API is introduced. No persistence keys, snapshots, runtime behavior, or UI copy change.