[https://nvbugs/6287721][chore] Unwaive Qwen3 FP8 weight-update tests - #16102
Conversation
|
/bot run --stage-list "DGX_B200-4_GPUs-PyTorch-Ray-1" |
WalkthroughThe Ray 4-GPU pre-merge list now runs explicit FP8 weight-update tests for Qwen3 8B and Qwen3 30B-A3B. The obsolete ChangesRay FP8 test selection
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #58151 [ run ] triggered by Bot. Commit: |
|
/bot run --stage-list "DGX_B200-4_GPUs-PyTorch-Ray-1" |
|
PR_Github #58176 [ run ] triggered by Bot. Commit: |
|
PR_Github #58151 [ run ] completed with state |
|
PR_Github #58176 [ run ] completed with state
|
|
/bot run --stage-list "DGX_B200-4_GPUs-PyTorch-Ray-1" |
1 similar comment
|
/bot run --stage-list "DGX_B200-4_GPUs-PyTorch-Ray-1" |
|
PR_Github #58252 [ run ] triggered by Bot. Commit: |
|
PR_Github #58252 [ run ] completed with state
|
|
/bot run --stage-list "DGX_B200-4_GPUs-PyTorch-Ray-1" |
|
PR_Github #58267 [ run ] triggered by Bot. Commit: |
|
PR_Github #58267 [ run ] completed with state |
|
/bot skip --comment "the unwaived tests passed" |
|
PR_Github #58929 [ skip ] triggered by Bot. Commit: |
|
PR_Github #58929 [ skip ] completed with state |
|
/bot run --stage-list "DGX_B200-4_GPUs-PyTorch-Ray-1" -- unittest/_torch/ray_orchestrator/multi_gpu/test_llm_update_weights_multi_gpu.py::test_llm_update_weights_fp8[Qwen3/Qwen3-8B-Qwen3/Qwen3-8B-FP8] --run-ray |
Head branch was pushed to by a user without write access
3f55b11 to
0f87f28
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/bot run |
|
PR_Github #65243 [ run ] triggered by Bot. Commit: |
|
PR_Github #65243 [ run ] completed with state
|
|
/bot run |
|
PR_Github #65261 [ run ] triggered by Bot. Commit: |
|
PR_Github #65261 [ run ] completed with state
|
|
/bot run |
|
PR_Github #65273 [ run ] triggered by Bot. Commit: |
brnguyen2
left a comment
There was a problem hiding this comment.
Approving — the comments below are optional touch-ups, not blockers.
Unwaive itself looks right: part0 currently contains exactly test_llm_update_weights_fp8[...8B] and [...30B-A3B], so the two explicit entries reproduce the old marker's coverage, and the part1/part4 waivers correctly stay.
Two things worth adding to the description: what actually fixed https://nvbugs/6287721 (or a link to the CI run that shows the two tests passing), and why the marker entry was replaced with explicit IDs rather than just dropping the waiver line.
|
PR_Github #65273 [ run ] completed with state |

Summary by CodeRabbit
part0and specific FP8 Qwen3 8B waivers.part1andpart4waivers.part0marker with explicit FP8 weight-update tests for Qwen3 8B and Qwen3 30B-A3B.Dev Engineer Review
QA Engineer Review
tests/integration/test_lists/waives.txt:part0waiver.part1andpart4waivers.tests/integration/test_lists/test-db/l0_dgx_b200.yml:part0marker-based entry.Description
PR #16700 waived the Ray orchestrator part0 update-weight tests under NVBug 6490036 after CI flakiness that could not be reproduced locally.
This PR restores the Qwen3 FP8 update-weight coverage by listing the two current part0 parameterizations as explicit test IDs:
Qwen3 8B → Qwen3 8B FP8
Qwen3 30B-A3B → Qwen3 30B-A3B FP8
Using explicit test IDs allows the two cases to be scheduled, diagnosed, and waived independently instead of running them through the shared part0 marker selection. The existing part1 and part4 waivers remain unchanged.
Test Coverage
Full pre-merge CI passed for commit 0f87f28, including the Multi-GPU test stage: L0_MergeRequest_PR #53050.
No product-code fix is included in this PR. The previously waived Qwen3 8B and Qwen3 30B-A3B FP8 cases now pass in pre-merge CI, so this PR restores their coverage using explicit test IDs.
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.