Skip to content

[CHORE] Drop unused __about__.py files from Python packages#551

Merged
Victor Schappert (vcschapp) merged 1 commit into
mainfrom
drop-about-py
Jul 15, 2026
Merged

[CHORE] Drop unused __about__.py files from Python packages#551
Victor Schappert (vcschapp) merged 1 commit into
mainfrom
drop-about-py

Conversation

@sethfitz

@sethfitz Seth Fitzsimmons (sethfitz) commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Closes #549.

Deletes the 12 __about__.py version shims. #534 moved every package to a static version in pyproject.toml and rewrote the shims to read importlib.metadata; nothing references __about__ or __version__ anywhere in the tree (verified across packages/, .github/, and the Makefile on current main).

#534 has merged, so this PR now targets main and drops the shims as dead code.

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

🗺️ Schema reference docs preview is live!

🌍 Preview https://staging.overturemaps.org/schema/pr/551/schema/index.html
🕐 Updated Jul 15, 2026 16:30 UTC
📝 Commit 1abba81
🔧 env SCHEMA_PREVIEW true

Note

♻️ This preview updates automatically with each push to this PR.

@sethfitz

Copy link
Copy Markdown
Collaborator Author

The failing Check (lowest-direct, py3.10) leg is unrelated to this change — typing_extensions 4.16.0 changed the MISSING sentinel repr that a Feature doctest pins. Tracked in #554.

Base automatically changed from 508-devops-branching-strategy---phase-2a---internal-versions to main July 13, 2026 17:03
@vcschapp

Copy link
Copy Markdown
Collaborator

Seth Fitzsimmons (@sethfitz) One check failing:

Check Python package code / Check (lowest-direct, py3.10) (pull_request)Failing after 44s

Looks like a single example test failed, and the problem looks like a Python output style change between 3.10 and 3.14?

Run make check
make[1]: Entering directory '/home/runner/work/schema/schema'
229 files already formatted
**********************************************************************
File "/home/runner/work/schema/schema/packages/overture-schema-system/src/overture/schema/system/feature.py", line 162, in overture.schema.system.feature.Feature
Failed example:
    FarmFeature.validate_json('''{
        "type": "Feature",
        "geometry": {
            "type": "LineString",
            "coordinates": [[0, 0], [0, 0.01]]
        },
        "properties": {
            "type": "fence",
            "subtype": "barb_wire_4"
        }
    }''')
Expected:
    Fence(id=<MISSING>, bbox=<MISSING>, geometry=<<LINESTRING (0 0, 0 0.01)>>, type='fence', subtype='barb_wire_4', height=None)
Got:
    Fence(id=MISSING, bbox=MISSING, geometry=<<LINESTRING (0 0, 0 0.01)>>, type='fence', subtype='barb_wire_4', height=None)
**********************************************************************
1 items had failures:
   1 of  18 in overture.schema.system.feature.Feature

PR #534 moved package versions to static declarations in pyproject.toml
and reduced __about__.py to thin shims that derive __version__ from
importlib.metadata. Nothing in packages/, .github/, or the Makefile
references __about__ or __version__, so the shims are dead code.

Signed-off-by: Seth Fitzsimmons <seth@mojodna.net>
@vcschapp
Victor Schappert (vcschapp) merged commit 467a550 into main Jul 15, 2026
19 checks passed
@vcschapp
Victor Schappert (vcschapp) deleted the drop-about-py branch July 15, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CHORE] Drop unused __about__.py files from Python packages

3 participants