[CHORE](actions) Fix app-id deprecation warning in check-linked-issue#56
Merged
Merged
Conversation
Pass appId via client-id input; create-github-app-token deprecated app-id. GitHub accepts numeric App ID as JWT issuer, so no behavior change. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: John McCall <john@overturemaps.org>
clientId takes precedence; appId kept as fallback for existing callers. deprecationMessage warns only when callers explicitly pass appId. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: John McCall <john@overturemaps.org>
Numeric App ID still works as the value; GitHub accepts either as JWT issuer. Default unchanged (2932845). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: John McCall <john@overturemaps.org>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: John McCall <john@overturemaps.org>
There was a problem hiding this comment.
Pull request overview
This PR updates the check-linked-issue composite action to stop emitting the actions/create-github-app-token v3 deprecation warning by switching from the deprecated app-id input to client-id, and aligns the action’s docs accordingly.
Changes:
- Renames the composite action input from
appIdtoclientIdand wires it toclient-idfor token generation. - Updates defaults/documentation in the action metadata and README to reference the GitHub App client ID.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/actions/check-linked-issue/action.yml | Renames the composite input and switches token generation to client-id. |
| .github/actions/check-linked-issue/README.md | Updates documented inputs/defaults to match the new clientId input. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55
actions/create-github-app-tokenv3.2.0 deprecatedapp-id→ warns every run.client-id(GitHub also still accepts numeric App ID as JWT issuer — no behavior change).appIdinput renamed toclientId; default updated to be Client ID, not App IDappIdexplicitly get a benign "unexpected input" warning; none exist in this repo, and the default covers normal use.