Skip to content

[CHORE](actions) Fix app-id deprecation warning in check-linked-issue #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
John McCall (lowlydba) merged 4 commits into from
Jul 15, 2026
Merged

[CHORE](actions) Fix app-id deprecation warning in check-linked-issue #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7969a52
Fix app-id deprecation warning in check-linked-issue action
lowlydba Jul 15, 2026
67f319f
Add clientId input, deprecate appId in check-linked-issue
lowlydba Jul 15, 2026
7d7f46a
Replace appId input with clientId in check-linked-issue
lowlydba Jul 15, 2026
0efbc55
Use real client ID as clientId default
lowlydba Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/check-linked-issue/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ permissions:

- `privateKey` (**required**): Private key for the `overture-check-linked-issue` GitHub App, used to generate an installation token for cross-repo GraphQL reads. Pass `${{ secrets.CHECK_LINKED_ISSUE_APP_PEM }}`. The value must include the full PEM block with a trailing newline.

- `appId` (optional): GitHub App ID. Defaults to `2932845` (the [Overture Check Linked Issues app](https://github.com/organizations/OvertureMaps/settings/apps/overture-check-linked-issue)) and does not normally need to be overridden.
- `clientId` (optional): GitHub App client ID. Defaults to `Iv23liJL38m6IaQFoD60`, the client ID of the [Overture Check Linked Issues app](https://github.com/organizations/OvertureMaps/settings/apps/overture-check-linked-issue) — GitHub accepts the numeric App ID here too. Does not normally need to be overridden.

Comment thread
lowlydba marked this conversation as resolved.
- `minimumLinkedIssues` (optional): Minimum number of linked issues required for the PR. Default is `1`. Set this input to require more than one linked issue:

Expand Down
11 changes: 7 additions & 4 deletions .github/actions/check-linked-issue/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,13 @@ inputs:
description: Minimum number of linked issues required
required: false
default: 1
appId:
description: GitHub App ID used to generate an installation token for cross-repo linked issue reads
clientId:
description: >
GitHub App client ID used to generate an installation token for
cross-repo linked issue reads. The numeric App ID also works here,
as GitHub accepts either as the JWT issuer.
Comment thread
lowlydba marked this conversation as resolved.
required: false
default: "2932845" #https://github.com/organizations/OvertureMaps/settings/apps/overture-check-linked-issue
default: "Iv23liJL38m6IaQFoD60" #https://github.com/organizations/OvertureMaps/settings/apps/overture-check-linked-issue
privateKey:
description: >
GitHub App private key used to generate an installation token.
Expand Down Expand Up @@ -50,7 +53,7 @@ runs:
if: ${{ inputs.privateKey != '' }}
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0 # zizmor: ignore[github-app,ref-version-mismatch] -- intentional: org-wide reusable workflow; dedicated GH App limits risk in lieu of per-repo scoping
with:
app-id: ${{ inputs.appId }}
client-id: ${{ inputs.clientId }}
Comment thread
lowlydba marked this conversation as resolved.
private-key: ${{ inputs.privateKey }}
owner: ${{ github.repository_owner }} # zizmor: ignore[github-app] -- intentional: org-wide reusable workflow; dedicated GH App limits risk in lieu of per-repo scoping

Expand Down
Loading