Bound DTLS handshakes with a monotonic deadline - #34
Open
Jason-Morcos wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
connect()currently starts its 12-second timeout after context and socket setup, measures it with wall time, and can overrun it by a final two-second receive. Callers also cannot request a shorter connection attempt.Changes
connect(timeout=...), retaining the 12-second default.Expiry continues to use the existing
SessionTimeoutError.Validation
The deadline tests use a deterministic monotonic clock and cover malformed values, setup time, shortened final polls, success at and after expiry, the default timeout, and successful session state.
Stack
Depends on #33. Until #33 merges, GitHub includes its certificate-profile commit in this PR's comparison; the new commit for this slice is
eae1aef.Planned follow-ups remain separate: connect cancellation/quiesce/abort, then graceful close and session generations.