chore(deps): bump TelnetNegotiationCore 2.5.1 → 2.5.2#16
Merged
Conversation
2.5.2 stops the client from proactively offering CHARSET (WILL CHARSET). A client/server WILL/WILL collision (RFC 2066) left CHARSET unresolved and made SharpMUSH discard the client's first line, so connecting to Convergence always bounced back to the login screen. With 2.5.2 the client only responds to the server's CHARSET offer, and login succeeds. Bumped in Core, Web, and App. Core + Web build clean; 194 Core tests pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HHCRc5CJ6595iMzEgYYdQp
There was a problem hiding this comment.
Pull request overview
Updates SharpClient’s Telnet negotiation dependency to pick up the upstream CHARSET negotiation fix that prevents a CHARSET WILL/WILL collision from breaking first-line login on affected servers (e.g., Convergence).
Changes:
- Bumped
TelnetNegotiationCorefrom2.5.1to2.5.2in Core, Web, and App projects. - Expanded the
SharpClient.Appproject comment to document the CHARSET negotiation behavior change and its user-visible impact.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/SharpClient.Web/SharpClient.Web.csproj | Updates TelnetNegotiationCore dependency to 2.5.2 for the web project. |
| src/SharpClient.Core/SharpClient.Core.csproj | Updates TelnetNegotiationCore dependency to 2.5.2 for the core library. |
| src/SharpClient.App/SharpClient.App.csproj | Updates TelnetNegotiationCore dependency to 2.5.2 and documents the CHARSET/login fix rationale. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls in TelnetNegotiationCore 2.5.2 — the CHARSET login fix (TNC #50).
Why
2.5.2 stops the client from proactively offering CHARSET (
WILL CHARSET). A client/serverWILL/WILLcollision (RFC 2066) left CHARSET unresolved, and in that stuck state SharpMUSH discarded the client's first line — so connecting to Convergence always bounced back to the login screen (for both stored auto-login and typedconnect). With 2.5.2 the client only responds to the server's CHARSET offer, and login succeeds. Verified live againstgame.convergencemush.orgduring the investigation.Changes
TelnetNegotiationCore2.5.1→2.5.2inSharpClient.Core,SharpClient.Web,SharpClient.App.Verification
SharpClient.CoreandSharpClient.Webbuild clean against 2.5.2.No server-side change needed — the fix is client-role behavior; the current 2.5.0 Convergence server is unaffected.
🤖 Generated with Claude Code