feat(generic): migrate for-core-styles from tup-ui - #561
Merged
Conversation
…pment Migrated from tup-ui's for-core-styles/components/ (c-news.css, c-news--read.css, c-news--list.css) — genuine Core-Styles gaps found while building tup-ui, not tup-specific overrides, so they belong here where every other project can discover and use them instead of independently re-patching the same Core-Styles gaps. c-news.css and c-news--read.css include tup-ui#325's pending edit (unmerged) composed in, since #325 will stop editing its local copies once tup-ui deletes them in favor of this. c-feed-list.css is not migrated: tup-ui#325 and #535 both delete it outright rather than keep it, so there is nothing to migrate.
Off-by-one blank line from the initial copy; content now matches tup-ui's source file exactly.
wesleyboar
changed the base branch from
main
to
feat/tup-static-asset-migration
August 3, 2026 19:47
…snippet c-news.css needs layer(base) to preserve its original cascade position, but a plain <link> can't assign a layer. Rather than add another raw <style>@import ...> block to the already-large ad-hoc CSS snippet, core-styles-feats.css does the @import-into-layer once, so the snippet can load it with a normal <link> like core-cms-fixes.css and core-styles-fixes.css. "feats" (this file) vs "fixes" (the existing ones): feats are base-layer components meant to be overridden; fixes are unlayered patches meant to win.
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
Aug 3, 2026
c-news.css, c-news--read.css, and c-news--list.css were general Core-Styles gaps found during tup-ui development, not tup-specific overrides, so they've moved to Core-CMS-Custom (TACC/Core-CMS-Custom#561) where other projects can find and use them. Loading moves to the ad-hoc CSS snippet (edited live in the CMS admin, already migrated to TACC/Core-CMS-Custom#559/#560) instead of assets_custom.html — no tup-ui code needs to load this CSS anymore.
Added a TODO comment for integration into Core-Styles.
wesleyboar
changed the title
wesleyboar
changed the title
wesleyboar
changed the title
for-core-styles from tup-ui
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
Aug 3, 2026
c-news.css and c-news--read.css: migrated to Core-CMS-Custom with this PR's edits composed in (TACC/Core-CMS-Custom#561, merged). c-feed-list.css, c-feed-list-tweaks.css, and tup-cms.for-core-styles.css: this PR's deletions/edits to these are already done independently in tup-ui#570 and #571.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Migrates
c-newsout of TACC/tup-ui'sfor-core-styles/folder.Details
These are genuine Core-Styles gaps discovered while building tup-ui — not tup-specific overrides — so this repo's
generic_assets/(nottup/) is the right home, since it's what other projects actually check for known Core-Styles/Core-CMS gaps.Related
for-core-styles(moved to diff repo) tup-ui#570Includes changes from:
Does not include
c-feed-list.csscuz it is deleted in:Changes
generic_assets/css/c-news.cssgeneric_assets/css/c-news--read.cssgeneric_assets/css/c-news--list.cssgeneric_assets/css/core-styles-feats.csstup/html/css-ad-hoc-styles.htmlTesting
for-core-styles/components/copy, with tup-ui#325's diff applied toc-news.cssandc-news--read.css.