feat(tup): migrate tup-ui static assets - #563
Draft
wesleyboar wants to merge 4 commits into
Draft
Conversation
Umbrella branch for the sub-PRs migrating tup-ui's static assets (css/, js/, and their html/ snippet wrappers) into this repo.
This was referenced Aug 3, 2026
…pment (#561) ## Overview Migrates `c-news.css`, `c-news--read.css`, and `c-news--list.css` out of [TACC/tup-ui's `for-core-styles/` folder](https://github.com/TACC/tup-ui/tree/v1.2.3/apps/tup-cms/src/taccsite_custom/tup_cms/static/tup_cms/css/for-core-styles). <details> These are genuine Core-Styles gaps discovered while building tup-ui — not tup-specific overrides — so this repo's `generic_assets/` (not `tup/`) is the right home, since it's what other projects actually check for known Core-Styles/Core-CMS gaps. </details> ## Related - adds to #563 - required by tup-ui#570 Includes changes from: - TACC/tup-ui#325 Does not include `c-feed-list.css` cuz it is deleted in: - TACC/tup-ui#325 - TACC/tup-ui#535 ## Changes - **added** `generic_assets/css/c-news.css` - **added** `generic_assets/css/c-news--read.css` - **added** `generic_assets/css/c-news--list.css` - **added** `generic_assets/css/core-styles-feats.css` (imports `c-news.css` into `layer(base)`, since a plain `<link>` can't assign a layer) - **updated** `tup/html/css-ad-hoc-styles.html` to load `core-styles-feats.css`, instead of adding another raw `<style>@import>` block to an already-large snippet ## Testing 1. Confirm each file's content matches tup-ui's current `for-core-styles/components/` copy, with tup-ui#325's diff applied to `c-news.css` and `c-news--read.css`. <!-- ## Notes … -->
## Overview Migrates CSS/JS assets (that `tup/html/css-ad-hoc-styles.html` and `js-ad-hoc-scripts.html` load) from [TACC/tup-ui] to here. <details> [TACC/tup-ui]: https://github.com/TACC/ The snippets files were already migrated (#559, #560); this closes the loop so those snippets' `<link>`/`<script>` tags can point at this repo's CDN pins instead of tup-ui's. </details> ## Related - adds to #563 - integrates changes from: - TACC/tup-ui#566 - TACC/tup-ui#535 - TACC/tup-ui#562 > [!IMPORTANT] > **Follow-up:** Repoint `tup/html/css-ad-hoc-styles.html` and `js-ad-hoc-scripts.html`'s CDN URLs at this repo (not done in this PR). ## Changes - **added** `tup/css/ad-hoc/` (many files) - **added** `tup/js/ad-hoc.js` - **added** `tup/js/ad-hoc/manage-participants-field-required-attr.js` - **added** `tup/css/ad-hoc/hide-blog-list-back-link.css` (from TACC/tup-ui#562, open) - **added** `tup/css/ad-hoc/adjust-logo.css` (from TACC/tup-ui#535, open) - **updated** `navbar-width-horz-scrollbar.css` ## Testing 1. Confirm each file's content matches TACC/tup-ui's current copy exactly **except**: - `navbar-width-horz-scrollbar.css` matches TACC/tup-ui#535's branch - `adjust-logo.css` matches TACC/tup-ui#535's branch (doesn't exist on tup-ui `main`) - `hide-blog-list-back-link.css` matches TACC/tup-ui#562's branch (doesn't exist on tup-ui `main`) - `ad-hoc.js`/`manage-participants-field-required-attr.js` matches the commit already pinned in the live snippet, TACC/tup-ui@0c0beee5
## Overview Migrates tup-ui's `for-tup-cms/` to here at `/tup/`. ## Related - adds to #563 - required by TACC/tup-ui#573 Includes changes from: - TACC/tup-ui#535 Does not include `breadcrumbs` cuz it is delete in: - TACC/tup-ui#535 ## Changes - **added** `tup/css/cms.css` - **added** `tup/css/_imports/**/*.css` - **added** `tup/css/_imports/components/banner` - **added** `tup/img/logo-*.svg` - **updated** `tup/README.md` ## Testing 1. Confirm each migrated file's content matches its tup-ui `for-tup-cms/`/`org_logos/` counterpart exactly (renames, and the breadcrumbs/footer drops, aside). 2. Confirm `tup/css/cms.css`'s `@import` list matches tup-ui's `tup-cms.for-tup-cms.css` 1-to-1 (minus the breadcrumbs import) just repathed to `./_imports/`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Migrate custom static assets from TACC/tup-ui.
Important
I want this now! I wait until WMA approves. See WC-499.
Related
Changes
/tup/generic_assets/c-news*/generic_assets/core-styles-feats.cssTesting
See the "sub PRs".