odb: add ability to specify the extraction rules for the assembly kit - #11032
odb: add ability to specify the extraction rules for the assembly kit#11032AcKoucher wants to merge 1 commit into
Conversation
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
There was a problem hiding this comment.
Code Review
This pull request introduces support for setting assembly extraction rules for inter-chip parasitics in 3D designs via a new -assembly flag in the set_extraction_rules_file command. It updates the database schema, serialization, and Tcl interface to store and manage the assembly extraction rules file path. The reviewer suggested using an else if block when validating the top chip in setAssemblyExtractionRulesFile to prevent potential null pointer dereference warnings from static analysis tools.
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@osamahammad21 and I discussed and we thought that it will be better to keep the paths of the extraction rules inside RCX until we have a proper data structure for the rules inside ODB. |
Summary
The idea is to specify the path for the assembly extraction rules and keep it in
dbDatabaseas for our current version there's single global assembly kit.I'm also fixing the condition for multiple techs when running
set_extraction_rules_path -techas the odb API I added was not accurate.Type of Change
Impact
None.
Verification
./etc/Build.sh).Related Issues
#11005