Skip to content

odb: add ability to specify the extraction rules for the assembly kit - #11032

Closed
AcKoucher wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:odb-assembly-rules
Closed

odb: add ability to specify the extraction rules for the assembly kit#11032
AcKoucher wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:odb-assembly-rules

Conversation

@AcKoucher

Copy link
Copy Markdown
Contributor

Summary

The idea is to specify the path for the assembly extraction rules and keep it in dbDatabase as for our current version there's single global assembly kit.

I'm also fixing the condition for multiple techs when running set_extraction_rules_path -tech as the odb API I added was not accurate.

Type of Change

  • New feature
  • Documentation update

Impact

None.

Verification

  • I have verified that the local build succeeds (./etc/Build.sh).
  • I have run the relevant tests and they pass.
  • My code follows the repository's formatting guidelines.
  • I have signed my commits (DCO).

Related Issues

#11005

Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
@AcKoucher AcKoucher self-assigned this Jul 30, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for setting assembly extraction rules for inter-chip parasitics in 3D designs via a new -assembly flag in the set_extraction_rules_file command. It updates the database schema, serialization, and Tcl interface to store and manage the assembly extraction rules file path. The reviewer suggested using an else if block when validating the top chip in setAssemblyExtractionRulesFile to prevent potential null pointer dereference warnings from static analysis tools.

Comment thread src/odb/src/db/dbDatabase.cpp
@AcKoucher
AcKoucher marked this pull request as ready for review July 30, 2026 17:06
@AcKoucher
AcKoucher requested a review from a team as a code owner July 30, 2026 17:06
@AcKoucher
AcKoucher requested a review from osamahammad21 July 30, 2026 17:06
@eder-matheus

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 17d2ed1dd7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@AcKoucher
AcKoucher marked this pull request as draft July 30, 2026 19:21
@AcKoucher AcKoucher closed this Jul 30, 2026
@AcKoucher

Copy link
Copy Markdown
Contributor Author

@osamahammad21 and I discussed and we thought that it will be better to keep the paths of the extraction rules inside RCX until we have a proper data structure for the rules inside ODB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants