node shmem: Reset Sample::signals before writing to shared memory#1020
Open
leonardocarreras wants to merge 1 commit into
Open
node shmem: Reset Sample::signals before writing to shared memory#1020leonardocarreras wants to merge 1 commit into
leonardocarreras wants to merge 1 commit into
Conversation
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shmem node writes samples whose
signalsfield is astd::shared_ptrinto the writer's heap. A reader in another process dereferences that pointer while copying the sample and crashes.Discovered when using two villas-node processes with shmem, it segfaults at the first read.