Skip to content

node shmem: Reset Sample::signals before writing to shared memory #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leonardocarreras wants to merge 1 commit into
base: master
Choose a base branch
from
Open

node shmem: Reset Sample::signals before writing to shared memory #1020

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/nodes/shmem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,10 @@ int villas::node::shmem_write(NodeCompat *n, struct Sample *const smps[],
if (copied < avail)
n->logger->warn("Outgoing pool underrun");

/* signals is a heap shared_ptr; a reader in another process can't deref it */
for (int i = 0; i < copied; i++)
shared_smps[i]->signals.reset();

pushed = shmem_int_write(&shm->intf, shared_smps, copied);
if (pushed != avail)
n->logger->warn("Outgoing queue overrun for node");
Expand Down