Add nudge unit#12
Open
freezy wants to merge 1 commit into
Open
Conversation
Greptile SummaryThis PR adds a Visual Scripting node for triggering player nudges. The main changes are:
Confidence Score: 4/5The new node depends on the resolved engine package exposing the exact
Runtime/Nodes/Nudge/NudgeUnit.cs Important Files Changed
Reviews (1): Last reviewed commit: "visualscripting: add nudge unit" | Re-trigger Greptile |
| return OutputTrigger; | ||
| } | ||
|
|
||
| Player.Nudge(flow.GetValue<float>(Angle), flow.GetValue<float>(Force)); |
There was a problem hiding this comment.
Player is provided by the referenced VisualPinball.Unity assembly, so this new call requires that package version to expose a compatible public Nudge(float, float) overload. If the resolved engine package lacks that exact API or uses a different signature, the Visual Scripting runtime assembly will fail to compile when this node is added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
NudgeVisual Scripting unit for table logic.Pinball > Nudgeunit.AngleandForceinputs.Player.Nudge(angle, force)and continues graph flow through the output trigger.This lets Visual Scripting tables trigger the same player nudge path used by the engine-side nudge implementation.