Migrate benches/bevy_scene/spawn.rs to use ui_widgets::Button (Extra Item 5) - #25194
Merged
Merged
Conversation
kfc35
added
A-UI
viridia
approved these changes
Jul 27, 2026
alice-i-cecile
added
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
bevy_scenebench was still using the old to-be-deprecated button. Just changed the import (had to addui_widgetsas a dependency).Testing
cargo bench -p benches --bench scenebetween both this branch and main and “no change in performance was detected” between the two for the ui scenes.