Skip to content

LabelResolutionPlugin registers label for ui_widgets::Button instead of ui::widgets::Button (Extra Item 6) - #25195

Merged
alice-i-cecile merged 1 commit into
bevyengine:mainfrom
kfc35:24112_label_resolution_button
Jul 28, 2026
Merged

LabelResolutionPlugin registers label for ui_widgets::Button instead of ui::widgets::Button (Extra Item 6)#25195
alice-i-cecile merged 1 commit into
bevyengine:mainfrom
kfc35:24112_label_resolution_button

Conversation

@kfc35

@kfc35 kfc35 commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Objective

Solution

  • ui_widgets::Button will replace ui::widgets::Button as Bevy’s “first-party” type for buttons, so use it instead in the LabelResolutionPlugin
  • Had to add ui_widgets as a dependency to the dev tools crate for this. (If we prefer to just remove the entry to avoid the dependency add, LMK)

Testing

  • This doesn’t seem to be used anywhere so… I guess I’ll depend on ci for this one

@kfc35 kfc35 changed the title LabelResolutionPlugin registers label for ui_widgets::Button Extra Item 6 LabelResolutionPlugin registers label for ui_widgets::Button instead of ui::widgets::Button (Extra Item 6) Jul 28, 2026
@kfc35 kfc35 added D-Trivial Nice and easy! A great choice to get started with Bevy A-UI Graphical user interfaces, styles, layouts, and widgets A-Dev-Tools Tools used to debug Bevy applications. S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 28, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in UI Jul 28, 2026
@kfc35 kfc35 mentioned this pull request Jul 28, 2026
Closed
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 28, 2026
@alice-i-cecile
alice-i-cecile added this pull request to the merge queue Jul 28, 2026
Merged via the queue into bevyengine:main with commit 85e5f8b Jul 28, 2026
53 checks passed
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in UI Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees

No one assigned

Labels

A-Dev-Tools Tools used to debug Bevy applications. A-UI Graphical user interfaces, styles, layouts, and widgets D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

UI
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kfc35 @alice-i-cecile