Skip to content

Correct French validator placeholders and typo from PR #3771 review thread - #3772

Merged
bobvandevijver merged 3 commits into
6.1from
copilot/fix-all-comments-in-review-thread
Aug 3, 2026
Merged

Correct French validator placeholders and typo from PR #3771 review thread#3772
bobvandevijver merged 3 commits into
6.1from
copilot/fix-all-comments-in-review-thread

Conversation

Copilot AI commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

This updates translations/validators.fr.xlf to resolve all comments in review thread #pullrequestreview-4845798667, including the “fix all mentioned occurrences” follow-up. The issue was mismatched placeholder keys in French targets (compare_* vs compared_*) and a typo that could break interpolation consistency.

  • Placeholder key alignment (compare_*compared_*)

    • Replaced incorrect French target placeholders with Symfony-compatible keys:
      • {{compare_value}}{{compared_value}}
      • {{compare_value_type}}{{compared_value_type}}
    • Applied across all referenced compare-message units, including the additional multiple-of occurrence in the same file.
  • French translation typo correction

    • Fixed mamaximummaximum in the collection size message.
<!-- before -->
<target>Cette valeur doit être égale à {{compare_value}}.</target>
<target>Cette valeur doit être identique à {{compare_value_type}} {{compare_value}}.</target>

<!-- after -->
<target>Cette valeur doit être égale à {{compared_value}}.</target>
<target>Cette valeur doit être identique à {{compared_value_type}} {{compared_value}}.</target>

Copilot AI changed the title [WIP] Fix code for all comments in review thread Correct French validator placeholders and typo from PR #3771 review thread Aug 3, 2026
Copilot AI requested a review from bobvandevijver August 3, 2026 15:32
@bobvandevijver

Copy link
Copy Markdown
Member

@copilot resolve the merge conflicts in this pull request

Copilot AI commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Resolved by merging base branch 6.1 and fixing the conflict in translations/validators.fr.xlf while preserving the placeholder fixes. Addressed in commit 255bdb2.

@bobvandevijver
bobvandevijver marked this pull request as ready for review August 3, 2026 15:39
@bobvandevijver
bobvandevijver requested review from Copilot and removed request for Copilot August 3, 2026 15:39
@bobvandevijver
bobvandevijver merged commit 825fc75 into 6.1 Aug 3, 2026
35 of 36 checks passed
@bobvandevijver
bobvandevijver deleted the copilot/fix-all-comments-in-review-thread branch August 3, 2026 15:40
@bobvandevijver bobvandevijver added this to the Bolt 6.1 milestone Aug 4, 2026
@bobvandevijver bobvandevijver added 🐛 tag: bug fix topic: Multilingual 🌐 Language, i10n, i18n, translations labels Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 tag: bug fix topic: Multilingual 🌐 Language, i10n, i18n, translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants