Move proto files under sapient_msg/ to match import paths - #13
Open
cafanasyev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align directory layout with proto import paths so files compile with plain protoc
All .proto files in this repository import each other via paths like import "sapient_msg/bsi_flex_335_v2_0/location.proto", but the files themselves live at the repository root without a sapient_msg/ directory.
Because protoc resolves imports as literal paths relative to -I, the repository cannot currently be compiled as-is — users have to rename the checkout directory or create symlinks first.
This PR:
Moves proto_options.proto, bsi_flex_335_v1_0/ and bsi_flex_335_v2_0/ into a new top-level sapient_msg/ directory, with no changes to message definitions. After this, both versions compile straight from the repository root:
protoc -I . --java_out=./out sapient_msg/proto_options.proto sapient_msg/bsi_flex_335_v1_0/*.proto sapient_msg/bsi_flex_335_v2_0/*.proto