FCE-3584: ScreenShareController and CustomSourceController - #594
Open
MiloszFilimowski wants to merge 1 commit into
Open
FCE-3584: ScreenShareController and CustomSourceController#594MiloszFilimowski wants to merge 1 commit into
MiloszFilimowski wants to merge 1 commit into
Conversation
ScreenShareController ports the screen-share lifecycle including the pre-connect no-publish branch (screen share before signalling is active) and FIXES FCE-3574: the tracks middleware is persisted into state and re-applied on a subsequent start (previously a stop/restart silently dropped it). CustomSourceController manages arbitrary user streams per source id with the TrackTypeError recovery path. Both are wired into the orchestrator, the store (screenShare/customSources slices), and the client API (startScreenShare/stopScreenShare/setScreenShareTracksMiddleware/ setCustomSource). react-client still runs its old screen-share path — the swap is the next PR.
MiloszFilimowski
changed the title
6 tasks
MiloszFilimowski
marked this pull request as ready for review
August 11, 2026 09:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #592.
Description
ScreenShareController: screen-share lifecycle as a tsunami controller, including the pre-connect no-publish branch (screen share while signalling is not yet active).CustomSourceController: arbitrary user streams per source id, with theTrackTypeErrorrecovery path.ClientState(screenShare/customSourcesslices), and the client API (startScreenShare/stopScreenShare/setScreenShareTracksMiddleware/setCustomSource).Motivation and Context
The last two controllers of the device layer (FCE-3584, FCE-3585). The FCE-3574 fix lands here because persistence is the controller's natural design, not a patch on the old hook.
Documentation impact
Types of changes
not work as expected)