FCE-3574: react-client screen share and custom sources read the tsunami store - #595
Open
MiloszFilimowski wants to merge 1 commit into
Open
Conversation
The provider's screen-share and custom-source contexts become store-backed memo adapters over the tsunami controllers; useScreenshareManager and useCustomSourceManager are deleted. One spec change — the FCE-3574 quirk assertion flips per its own documented intent: setTracksMiddleware now persists the middleware, so currentTracksMiddleware reflects it and it is re-applied on a subsequent startStreaming.
MiloszFilimowski
changed the title
This was referenced Aug 11, 2026
MiloszFilimowski
marked this pull request as ready for review
August 11, 2026 09:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #594.
Description
useScreenshareManageranduseCustomSourceManagerare deleted (−451 lines net).screenShare.spec.tsflips per its own documented intent —setTracksMiddlewarenow persists the middleware, socurrentTracksMiddlewarereflects it and it is re-applied on restart. Sign-off recorded 2026-08-04.Motivation and Context
Closes the react-client side of FCE-3584/FCE-3585 and the FCE-3574 fix. With this PR every media path in react-client (camera, microphone, screen share, custom sources) runs on tsunami; 69/69 specs pass.
Documentation impact
Types of changes
not work as expected)