FCE-3579: voice activity detection as a high-frequency channel - #598
Open
MiloszFilimowski wants to merge 1 commit into
Open
FCE-3579: voice activity detection as a high-frequency channel#598MiloszFilimowski wants to merge 1 commit into
MiloszFilimowski wants to merge 1 commit into
Conversation
VoiceActivityMonitor polls getLocalTrackAudioLevel and notifies through direct callbacks, bypassing the store — VAD fires tens of times per second and would defeat structural sharing if routed through ClientState. react-client's useVAD/useLocalVAD consume the monitor; useLocalVAD's polling body is deleted.
MiloszFilimowski
changed the title
6 tasks
MiloszFilimowski
marked this pull request as ready for review
August 11, 2026 09:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #597.
Description
VoiceActivityMonitor: pollsgetLocalTrackAudioLeveland notifies through direct callbacks, bypassing the store — VAD fires tens of times per second and would defeat structural sharing if routed throughClientState.useVAD/useLocalVADconsume the monitor;useLocalVAD's own polling body is deleted.Motivation and Context
The high-frequency signal channel from RFC 0015 §3 (FCE-3579): the store is for renderable state, high-frequency signals get a direct path.
Documentation impact
Types of changes
not work as expected)