fix(presets): fail closed on unreadable provenance - #4092
Open
marcelsafin wants to merge 1 commit into
Open
Conversation
Assisted-by: GitHub Copilot (model: gpt-5.6-sol, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fails closed when constitution provenance cannot be read, preventing read errors from interrupting preset removal.
Changes:
- Handles
OSErrorduring provenance reads. - Adds regression coverage for unreadable provenance.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/specify_cli/presets/__init__.py |
Treats provenance read failures as non-matches. |
tests/test_presets.py |
Tests the unreadable-provenance case. |
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
_constitution_provenance_matches_preset()already treats missing, invalid JSON, and undecodable provenance as a non-match, but anOSErrorwhile reading the same metadata escapes and can interrupt preset handling.This fails closed for read errors as well: unreadable provenance never authorizes a preset match.
Testing
uv run specify --helpuv sync && uv run pytest(6,652 passed, 177 skipped)Path.read_textfailureuvx ruff@0.15.0 check src testscleanAI Disclosure
Implemented autonomously by GitHub Copilot CLI (model: GPT-5.6 Sol) under human direction; a failing regression was added before the fix, then the full suite and lint were run locally. Commit includes
Assisted-byandCo-authored-bytrailers.