Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/specify_cli/presets/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def _constitution_provenance_matches_preset(
return False
try:
metadata = json.loads(provenance.read_text(encoding="utf-8"))
except (json.JSONDecodeError, UnicodeDecodeError):
except (OSError, json.JSONDecodeError, UnicodeDecodeError):
return False
return (
isinstance(metadata, dict)
Expand Down
24 changes: 24 additions & 0 deletions tests/test_presets.py
Original file line number Diff line number Diff line change
Expand Up @@ -784,6 +784,30 @@ def test_list_by_priority_includes_disabled_when_requested(self, temp_dir):
# ===== PresetManager Tests =====


def test_unreadable_constitution_provenance_fails_closed(
project_dir, monkeypatch
):
from specify_cli.presets import _constitution_provenance_matches_preset

memory = project_dir / ".specify" / "memory" / "constitution.md"
memory.parent.mkdir(parents=True, exist_ok=True)
memory.write_text("# Constitution\n", encoding="utf-8")
provenance = memory.parent / ".constitution-template.json"
provenance.write_text("{}", encoding="utf-8")
real_read_text = Path.read_text

def unreadable(path, *args, **kwargs):
if path == provenance:
raise OSError("simulated read failure")
return real_read_text(path, *args, **kwargs)

monkeypatch.setattr(Path, "read_text", unreadable)

assert not _constitution_provenance_matches_preset(
project_dir, memory, "example", "1.0.0"
)


class TestPresetManager:
"""Test PresetManager installation and removal."""

Expand Down