Skip to content

fix(bundler): reject non-string catalog tags - #4093

Open
marcelsafin wants to merge 1 commit into
github:mainfrom
marcelsafin:fix/bundle-catalog-string-tags
Open

fix(bundler): reject non-string catalog tags#4093
marcelsafin wants to merge 1 commit into
github:mainfrom
marcelsafin:fix/bundle-catalog-string-tags

Conversation

@marcelsafin

Copy link
Copy Markdown
Contributor

Description

Bundle catalog tags are declared as a list of strings, but _parse_tags() currently applies str() to every member. Mixed lists such as ["valid", 1] are silently normalized instead of rejected as invalid catalog data.

This validates every tag member and returns the original strings without coercion.

Testing

  • Tested locally with uv run specify --help
  • Ran existing tests with uv sync && uv run pytest (6,652 passed, 177 skipped)
  • Added a contract regression for mixed string/non-string tags
  • uvx ruff@0.15.0 check src tests clean

AI Disclosure

  • I did not use AI assistance for this contribution
  • I did use AI assistance (describe below)

Implemented autonomously by GitHub Copilot CLI (model: GPT-5.6 Sol) under human direction; a failing contract regression was added before the fix, then the full suite and lint were run locally. Commit includes Assisted-by and Co-authored-by trailers.

Assisted-by: GitHub Copilot (model: gpt-5.6-sol, autonomous)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@marcelsafin
marcelsafin requested a review from mnriem as a code owner August 12, 2026 22:05
Copilot AI balanced review requested due to automatic review settings August 12, 2026 22:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Rejects malformed catalog tags instead of coercing non-string values.

Changes:

  • Validates every tag is a string.
  • Adds regression coverage for mixed-type tag lists.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/specify_cli/bundler/models/catalog.py Validates tag members before tuple conversion.
tests/contract/test_catalog_schema.py Tests rejection of non-string tags.

馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants