fix(bundler): reject non-string catalog tags - #4093
Open
marcelsafin wants to merge 1 commit into
Open
Conversation
Assisted-by: GitHub Copilot (model: gpt-5.6-sol, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Rejects malformed catalog tags instead of coercing non-string values.
Changes:
- Validates every tag is a string.
- Adds regression coverage for mixed-type tag lists.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/specify_cli/bundler/models/catalog.py |
Validates tag members before tuple conversion. |
tests/contract/test_catalog_schema.py |
Tests rejection of non-string tags. |
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bundle catalog tags are declared as a list of strings, but
_parse_tags()currently appliesstr()to every member. Mixed lists such as["valid", 1]are silently normalized instead of rejected as invalid catalog data.This validates every tag member and returns the original strings without coercion.
Testing
uv run specify --helpuv sync && uv run pytest(6,652 passed, 177 skipped)uvx ruff@0.15.0 check src testscleanAI Disclosure
Implemented autonomously by GitHub Copilot CLI (model: GPT-5.6 Sol) under human direction; a failing contract regression was added before the fix, then the full suite and lint were run locally. Commit includes
Assisted-byandCo-authored-bytrailers.