Skip to content

fix(bundler): reject non-string catalog tags #4093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcelsafin wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

fix(bundler): reject non-string catalog tags #4093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/specify_cli/bundler/models/catalog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,11 @@ def _parse_tags(value: Any, entry_id: str) -> tuple[str, ...]:
raise BundlerError(
f"Catalog entry '{entry_id}': 'tags' must be a list of strings."
)
return tuple(str(t) for t in value)
if any(not isinstance(tag, str) for tag in value):
raise BundlerError(
f"Catalog entry '{entry_id}': 'tags' must be a list of strings."
)
return tuple(value)


def _parse_verified(value: Any, entry_id: str) -> bool:
Expand Down
9 changes: 9 additions & 0 deletions tests/contract/test_catalog_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,15 @@ def test_catalog_entry_rejects_string_tags():
CatalogEntry.from_dict(data)


def test_catalog_entry_rejects_non_string_tag_members():
from specify_cli.bundler.models.catalog import CatalogEntry

data = catalog_entry_dict("demo")
data["tags"] = ["valid", 1]
with pytest.raises(BundlerError, match="'tags' must be a list of strings"):
CatalogEntry.from_dict(data)


def test_catalog_entry_rejects_non_boolean_verified():
from specify_cli.bundler.models.catalog import CatalogEntry

Expand Down